• LittleHermiT
    link
    fedilink
    English
    arrow-up
    6
    ·
    1 year ago

    Strange, I get a mild hostility vibe from colleagues if I review too ambitiously.

    • jadero@programming.dev
      link
      fedilink
      arrow-up
      2
      ·
      1 year ago

      Reviews have to be balanced to circumstance. There is a big difference between putting out the sales brochure and the notice on the bulletin board. Likewise in coding a cryptographic framework for general consumption and that little script to create personal slideshows based on how you’ve tagged your photos.

      As a general rule, wider distributions, public distributions, and long-lived distributions need more ambitious reviews. If the distribution is wide, public, and permanent, then everything needs very detailed scrutiny.

      I have found some success in starting with and occasionally revisiting review goals. This helps create and maintain some consistency in a process that is scaled to the task at hand.